johnjcasey commented on PR #24156: URL: https://github.com/apache/beam/pull/24156#issuecomment-1317177121
> We have a couple of Legacy/Classic templates for Spanner [1]. I agree on new templates being Flex, that's a route we want to pursue, including migrating classic to Flex when feasible. With this change in specific, we have some inheritance from Beam that requires some rework, so I am trying to keep it consistent. > > Not changing to a ValueProvider would mean that we can only configure a subset of the parameters (or at this time, all but one). > > [1] https://github.com/GoogleCloudPlatform/DataflowTemplates/tree/main/v1/src/main/java/com/google/cloud/teleport/spanner got it. If we are already using this for classic templates, we should keep it consistent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
