TheNeuralBit commented on PR #23701: URL: https://github.com/apache/beam/pull/23701#issuecomment-1317491823
> @TheNeuralBit where did you see that yapf is unhappy? In the "PythonFormatter" check. You can click Details in the GitHub UI to get to the logs from that Jenkins job. Here's the current output: ``` 10:04:21 py3-yapf-check run-test: commands[1] | time yapf --diff --parallel --recursive apache_beam 10:04:59 --- apache_beam/transforms/util_test.py (original) 10:04:59 +++ apache_beam/transforms/util_test.py (reformatted) 10:04:59 @@ -203,8 +203,8 @@ 10:04:59 res = ( 10:04:59 p 10:04:59 | beam.Create(range(35)) 10:04:59 - | util.BatchElements(min_batch_size=10, max_batch_size=10, 10:04:59 - record_metrics=False) 10:04:59 + | util.BatchElements( 10:04:59 + min_batch_size=10, max_batch_size=10, record_metrics=False) 10:04:59 | beam.Map(len)) 10:04:59 assert_that(res, equal_to([10, 10, 10, 5])) ``` > Running it on utils.py changes a lot of things that I did not touch :) Yeah I run into this occassionally. Typically I'll just only run it on the files that I've edited, and if it changes sections that I didn't edit I'll use `git add -i` to just commit changes to the parts that I edited. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
