olehborysevych commented on code in PR #24144: URL: https://github.com/apache/beam/pull/24144#discussion_r1025387952
########## playground/terraform/infrastructure/cloudbuild-manual-setup/02.builders/variables.tf: ########## @@ -0,0 +1,58 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +variable "project" { + type = string + description = "The ID of the Google Cloud project within which resources are provisioned" +} + +variable "region" { + type = string + description = "The Google Cloud Platform (GCP) region in which to provision resources" +} + +variable "github_repository_name" { + type = string + description = "The name of the GitHub repository. For example the repository name for https://github.com/example/foo is 'foo'." +} + +variable "github_repository_owner" { + type = string + description = "Owner of the GitHub repository. For example the owner for https://github.com/example/foo is 'example'." +} + +variable "github_repository_branch" { + type = string + description = "The GitHub repository branch name to match cloud build trigger" +} + +variable "infra_trigger_id" { + type = string + description = "The name of the trigger that will deploy Playground infrastructure" Review Comment: This is actually an Id not a name, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
