judahrand commented on PR #24249: URL: https://github.com/apache/beam/pull/24249#issuecomment-1319957726
In fact, does the basic test not prove that this is still broken? https://github.com/apache/beam/blob/cf56af2799f61dd4fc02923e7f23f421723765c6/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java#L458-L476 Given that the final value of the `COALESCE` in this test is a `STRING` the return type should be `STRING NOT NULL` but the test asserts that it is `NULLABLE`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
