echauchot commented on code in PR #24009:
URL: https://github.com/apache/beam/pull/24009#discussion_r1026481858
##########
runners/spark/3/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/TransformTranslator.java:
##########
@@ -118,69 +126,53 @@ public <T> PCollection<T> getOutput(TupleTag<T> tag) {
return pc;
}
- public Map<TupleTag<?>, PCollection<?>> getOutputs() {
- return transform.getOutputs();
- }
-
public AppliedPTransform<InT, OutT, PTransform<InT, OutT>>
getCurrentTransform() {
return transform;
}
+ @Override
public <T> Dataset<WindowedValue<T>> getDataset(PCollection<T>
pCollection) {
- return cxt.getDataset(pCollection);
+ return state.getDataset(pCollection);
}
- public <T> void putDataset(PCollection<T> pCollection,
Dataset<WindowedValue<T>> dataset) {
- cxt.putDataset(pCollection, dataset);
+ @Override
+ public <T> void putDataset(
+ PCollection<T> pCollection, Dataset<WindowedValue<T>> dataset, boolean
noCache) {
Review Comment:
yes and it even more difficult to read with noCache = false :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
