ryanthompson591 commented on code in PR #23870:
URL: https://github.com/apache/beam/pull/23870#discussion_r1026496365
##########
sdks/python/scripts/run_pylint.sh:
##########
@@ -64,6 +64,11 @@ while IFS= read -d $'\0' -r file ; do
EXCLUDED_GENERATED_FILES+=("$file")
done < <(find apache_beam/portability/api -type f -name "*pb2*.py" -print0)
+# Ignore vendor files.
+while IFS= read -d $'\0' -r file ; do
+ EXCLUDED_GENERATED_FILES+=("$file")
Review Comment:
yeah, EXCLUDED_FILES seems better.
##########
sdks/python/setup.py:
##########
@@ -232,12 +232,8 @@ def get_portability_package_data():
# The issue was fixed in version 1.9.2.1
'crcmod>=1.7,<2.0',
'orjson<4.0',
Review Comment:
Done
##########
build.gradle.kts:
##########
@@ -170,6 +170,9 @@ tasks.rat {
// Ignore typesciript package management.
"sdks/typescript/package-lock.json",
"sdks/typescript/node_modules/**/*",
+
+ // Ignore third party vendored files
+ "sdks/python/vendor/**/*",
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
