kennknowles commented on code in PR #24253:
URL: https://github.com/apache/beam/pull/24253#discussion_r1026729179
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -995,7 +995,8 @@ class BeamModulePlugin implements Plugin<Project> {
'org.checkerframework.checker.nullness.NullnessChecker'
]
- if (!parseBooleanProperty(project, 'enableCheckerFramework') &&
!project.jenkins.isCIBuild) {
+ // Only skip checkerframework if explicitly requested
+ if (project.hasProperty('enableCheckerFramework') &&
!parseBooleanProperty(project, 'enableCheckerFramework')) {
Review Comment:
Yea good call of course. Classic. I don't _think_ there is any groovy
weirdness. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
