TheNeuralBit commented on a change in pull request #12132:
URL: https://github.com/apache/beam/pull/12132#discussion_r451186550



##########
File path: sdks/python/tox.ini
##########
@@ -287,3 +287,12 @@ deps =
 commands =
   yapf --version
   time yapf --diff --parallel --recursive apache_beam
+
+[testenv:py3-dependency-check]
+# TODO: botocore, a part of [interactive], wants docutils<0.16, but Sphinx
+# pulls in the latest docutils. Uncomment this line once botocore does not
+# conflict with Sphinx:
+# extras = docs,test,gcp,aws,interactive,interactive_test
+extras = test,gcp,aws,interactive,interactive_test
+commands =
+  time {toxinidir}/scripts/run_dependency_check.sh

Review comment:
       I think you need to add `passenv = WORKSPACE` here, otherwise the script 
fails because WORKSPACE isn't set.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to