pabloem commented on code in PR #24272:
URL: https://github.com/apache/beam/pull/24272#discussion_r1028604388
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -678,6 +680,8 @@ class BeamModulePlugin implements Plugin<Project> {
joda_time :
"joda-time:joda-time:2.10.10",
jsonassert :
"org.skyscreamer:jsonassert:1.5.0",
jsr305 :
"com.google.code.findbugs:jsr305:$jsr305_version",
+ json_org :
"org.json:json:${json_org_version}",
Review Comment:
thanks for the observation @Abacn - let's keep this discussion in
https://github.com/apache/beam/pull/24271 where the code is added? : )
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -678,6 +680,8 @@ class BeamModulePlugin implements Plugin<Project> {
joda_time :
"joda-time:joda-time:2.10.10",
jsonassert :
"org.skyscreamer:jsonassert:1.5.0",
jsr305 :
"com.google.code.findbugs:jsr305:$jsr305_version",
+ json_org :
"org.json:json:${json_org_version}",
Review Comment:
this PR is blocked by https://github.com/apache/beam/pull/24271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
