pabloem commented on code in PR #24271:
URL: https://github.com/apache/beam/pull/24271#discussion_r1029932939
##########
sdks/java/core/build.gradle:
##########
@@ -91,6 +91,8 @@ dependencies {
shadow library.java.avro
shadow library.java.snappy_java
shadow library.java.joda_time
+ shadow library.java.json_org
+ shadow library.java.everit_json_schema
Review Comment:
I've marked is as a `provided` dependency.
Before moving forward - another possibility is to create a new extension
module to hold these dependencies and this functionality. The module would be
used by some of our schema transform implementations (kafka and pubsub), so it
would still come back as a depenency for other Beam modules, but not for core -
wdyt?
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -678,6 +680,8 @@ class BeamModulePlugin implements Plugin<Project> {
joda_time :
"joda-time:joda-time:2.10.10",
jsonassert :
"org.skyscreamer:jsonassert:1.5.0",
jsr305 :
"com.google.code.findbugs:jsr305:$jsr305_version",
+ json_org :
"org.json:json:${json_org_version}",
Review Comment:
done thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
