lukecwik edited a comment on pull request #12192:
URL: https://github.com/apache/beam/pull/12192#issuecomment-655239038


   R: @robertwb @chamikaramj 
   
   Progress reporting needs to be able to see which window out of how many are 
being processed. Splitting needs to be able to see which window is being 
processed to compute the primary and residual correctly.
   
   Alternatively, I could move the window observing logic outside of the 
DoFnInvoker and then all the DoFnRunners would own this logic (this does seem 
like it would lead to more code duplication).
   
   WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to