alexeyinkin commented on code in PR #24338:
URL: https://github.com/apache/beam/pull/24338#discussion_r1031509793
##########
playground/frontend/lib/modules/examples/components/example_list/category_expansion_panel.dart:
##########
@@ -27,18 +27,15 @@ import
'package:playground_components/playground_components.dart';
class CategoryExpansionPanel extends StatelessWidget {
final String categoryName;
final List<ExampleBase> examples;
+ final VoidCallback onSelected;
final ExampleBase selectedExample;
- final AnimationController animationController;
- final OverlayEntry? dropdown;
const CategoryExpansionPanel({
- Key? key,
Review Comment:
I think keys must be in library widgets where the user does not control the
code. In apps keys can be added as needed. We only use keys on 5 occasions,
most of them due to bad design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
