alexeyinkin commented on code in PR #24338:
URL: https://github.com/apache/beam/pull/24338#discussion_r1031610660
##########
playground/frontend/playground_components/lib/src/controllers/example_loaders/example_loader.dart:
##########
@@ -17,9 +17,12 @@
*/
import '../../models/example.dart';
+import '../../models/sdk.dart';
abstract class ExampleLoader {
const ExampleLoader();
+ Sdk? get sdk;
Review Comment:
1. If one subclass does not have a property, it is not a property of the
superclass. This is the core of inheritance.
2. `UserSharedExampleLoadingDescriptor` also has no `Sdk`.
3. There are loaders with non-nullable `Sdk` which we will lose this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
