eantyshev commented on PR #24287: URL: https://github.com/apache/beam/pull/24287#issuecomment-1328298891
After some thought, decided to get rid of service-wide secret completely First, having a system-wide secret is not a good practice [owasp guidelines for storing passwords](https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#salting) Second, we don't have to re-caclulate persistence_key every call: we can calculate it once and store in tb_user_progress entity. This removes over-complication in `generatePersistenceKey`, as it doesn't need to depend on (SDK, unitID, userID), if we choose a secure random source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
