Malarg commented on code in PR #24338: URL: https://github.com/apache/beam/pull/24338#discussion_r1033133472
########## playground/frontend/lib/modules/examples/example_selector.dart: ########## @@ -16,23 +16,21 @@ * limitations under the License. */ +import 'dart:async'; + import 'package:flutter/material.dart'; -import 'package:flutter_gen/gen_l10n/app_localizations.dart'; -import 'package:playground/constants/links.dart'; import 'package:playground/constants/sizes.dart'; -import 'package:playground/modules/examples/components/examples_components.dart'; import 'package:playground/modules/examples/components/outside_click_handler.dart'; +import 'package:playground/modules/examples/examples_dropdown_content.dart'; import 'package:playground/modules/examples/models/popover_state.dart'; import 'package:playground/pages/playground/states/example_selector_state.dart'; import 'package:playground/utils/dropdown_utils.dart'; import 'package:playground_components/playground_components.dart'; import 'package:provider/provider.dart'; -import 'package:url_launcher/url_launcher.dart'; const int kAnimationDurationInMilliseconds = 80; const Offset kAnimationBeginOffset = Offset(0.0, -0.02); Review Comment: Yes, so I suggest to move these constants to `feedback_dropdown_icon_button.dart`. Or in general constants file, if you are sure that they will be used somewhere else -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
