chamikaramj commented on code in PR #24344:
URL: https://github.com/apache/beam/pull/24344#discussion_r1033894522
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java:
##########
@@ -264,6 +264,19 @@ public static Schema of(Field... fields) {
return Schema.builder().addFields(fields).build();
}
+ /** Returns an identical Schema with sorted fields. */
+ public Schema sorted() {
+ Schema sortedSchema =
Review Comment:
Can we add an assertion or a unit test that will break if any new properties
are added to the Schema object that are not copied over here ?
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/TypedSchemaTransformProvider.java:
##########
@@ -40,6 +40,9 @@
*/
@Internal
@Experimental(Kind.SCHEMAS)
+@SuppressWarnings({
+ "nullness" // TODO(https://github.com/apache/beam/issues/20506)
Review Comment:
What's the error you got here ? We should try to fix checker-framework
warnings in new code instead of surpassing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
