lostluck commented on PR #24421: URL: https://github.com/apache/beam/pull/24421#issuecomment-1331496654
> > Technically a breaking change, but only for uses we don't support anyway. > > I thought this isn't a breaking change, since we are just adding an optional, variadic param? Turns out that Go has no safe type changes one can make to Exported identifiers. `OutputType` has a function type of `func(t reflect.Type)`, which means we could previously assign it to a `var foo func(reflect.Type)` if we wanted. That would fail now because you can't assign a `func(reflect.Type, ... typex.FullType)` to `func(reflect.Type)`. Since this isn't a pattern we advocate for or demo, it's acceptable in my view, even though it can break a compile for someone. In this case, it's very obvious that something is broken and that the fix is generally pretty obvious. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
