thiagotnunes commented on code in PR #24390:
URL: https://github.com/apache/beam/pull/24390#discussion_r1035472413
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/mapper/ChangeStreamRecordMapper.java:
##########
@@ -83,30 +90,41 @@ public class ChangeStreamRecordMapper {
private static final String CHILD_PARTITIONS_COLUMN = "child_partitions";
private static final String PARENT_PARTITION_TOKENS_COLUMN =
"parent_partition_tokens";
private static final String TOKEN_COLUMN = "token";
+ private final Dialect dialect;
+ private final JsonFormat.Printer printer;
+ private final JsonFormat.Parser parser;
- ChangeStreamRecordMapper() {}
+ ChangeStreamRecordMapper(Dialect dialect) {
+ this.dialect = dialect;
+
+ this.printer =
Review Comment:
I don't think we will call these concurrently, but do you know if they are
thread-safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
