damondouglas commented on code in PR #24227: URL: https://github.com/apache/beam/pull/24227#discussion_r1036138007
########## playground/infrastructure/helm-playground/templates/autoscaling-java.yaml: ########## @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +apiVersion: autoscaling/v1 +kind: HorizontalPodAutoscaler +metadata: + name: playground-java +spec: + maxReplicas: 10 + minReplicas: 2 Review Comment: Why is this one configured with `2` while the others `1`? ########## playground/infrastructure/helm-playground/templates/deployment-python.yml: ########## @@ -38,6 +38,27 @@ spec: value: "remote" - name: CACHE_ADDRESS value: {{ .Values.redis_ip }} + - name: NUM_PARALLEL_JOBS + value: "5" + livenessProbe: + httpGet: + path: /liveness + port: 8080 + initialDelaySeconds: 3 + periodSeconds: 3 + readinessProbe: + httpGet: + path: /readiness + port: 8080 Review Comment: Similar to the comment above, can we populate the port parameter from a helm variable? ########## playground/infrastructure/helm-playground/templates/deployment-go.yml: ########## @@ -39,6 +39,27 @@ spec: value: "remote" - name: CACHE_ADDRESS value: {{ .Values.redis_ip }} + - name: NUM_PARALLEL_JOBS + value: "5" + livenessProbe: + httpGet: + path: /liveness + port: 8080 + initialDelaySeconds: 3 + periodSeconds: 3 + readinessProbe: + httpGet: + path: /readiness + port: 8080 Review Comment: Similar to the comment above, can we populate the port parameter from a helm variable? ########## playground/infrastructure/helm-playground/templates/deployment-java.yml: ########## @@ -38,6 +38,27 @@ spec: value: "remote" - name: CACHE_ADDRESS value: {{ .Values.redis_ip }} + - name: NUM_PARALLEL_JOBS + value: "5" + livenessProbe: + httpGet: + path: /liveness + port: 8080 + initialDelaySeconds: 3 + periodSeconds: 3 + readinessProbe: + httpGet: + path: /readiness + port: 8080 Review Comment: Similar to the comment above, can we populate the port parameter from a helm variable? ########## playground/infrastructure/helm-playground/templates/deployment-scio.yml: ########## @@ -37,6 +37,27 @@ spec: value: "remote" - name: CACHE_ADDRESS value: {{ .Values.redis_ip }} + - name: NUM_PARALLEL_JOBS + value: "5" + livenessProbe: + httpGet: + path: /liveness + port: 8080 + initialDelaySeconds: 3 + periodSeconds: 3 + readinessProbe: + httpGet: + path: /readiness + port: 8080 Review Comment: Similar to the comment above, can we populate the port parameter from a helm variable? ########## playground/infrastructure/helm-playground/values.yaml: ########## @@ -29,4 +29,12 @@ autoscaling: enabled: false minReplicas: 1 maxReplicas: 4 - targetCPUUtilizationPercentage: 80 \ No newline at end of file + targetCPUUtilizationPercentage: 80 +static_ip: 34.120.95.76 +redis_ip: 10.226.29.100:6379 +project_id: astst-369706 +registry: us-east1-docker.pkg.dev/astst-369706/playground-repository +static_ip_name: pg-static-ip +tag: teta +dns_name: dev-playground.online Review Comment: Do we want to hardcode these? ########## playground/infrastructure/helm-playground/templates/deployment-router.yml: ########## @@ -40,6 +40,27 @@ spec: value: "remote" - name: CACHE_ADDRESS value: {{ .Values.redis_ip }} + - name: NUM_PARALLEL_JOBS + value: "5" + livenessProbe: + httpGet: + path: /liveness + port: 8080 + initialDelaySeconds: 3 + periodSeconds: 3 + readinessProbe: + httpGet: + path: /readiness + port: 8080 Review Comment: Similar to the comment above, can we populate the port parameter from a helm variable? ########## playground/infrastructure/helm-playground/templates/deployment-frontend.yml: ########## @@ -34,6 +34,25 @@ spec: imagePullPolicy: {{ .Values.image.pullPolicy }} ports: - containerPort: 8080 + livenessProbe: + httpGet: + path: /liveness + port: 8080 + initialDelaySeconds: 3 + periodSeconds: 3 + readinessProbe: + httpGet: + path: /readiness + port: 8080 + initialDelaySeconds: 3 + periodSeconds: 3 + resources: + requests: + memory: "50Mi" + cpu: "250m" + limits: + cpu: "500" + memory: "500Mi" Review Comment: How was the values `50Mi`, `250m`, `500`, and `500Mi` determined? I wouldn't know myself and not a blocker for this PR. I was just curious and thank you. ########## playground/infrastructure/helm-playground/templates/deployment-frontend.yml: ########## @@ -34,6 +34,25 @@ spec: imagePullPolicy: {{ .Values.image.pullPolicy }} ports: - containerPort: 8080 + livenessProbe: + httpGet: + path: /liveness + port: 8080 + initialDelaySeconds: 3 + periodSeconds: 3 + readinessProbe: + httpGet: + path: /readiness + port: 8080 Review Comment: Is it possible for the `8080` to be acquired from a helm variable to populate `ports.containerPort`, `livenessProbe.httpGet.port`, and `readinessProbe.httpGet.port`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
