BjornPrime commented on code in PR #24435:
URL: https://github.com/apache/beam/pull/24435#discussion_r1036310255
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -2475,7 +2475,7 @@ def typed(transform):
def inject_default(_, combined):
if combined:
- assert len(combined) == 1
+ assert len(combined) >= 1
Review Comment:
In this case we've just changed the assertion to allow for "combined" longer
than one. This doesn't throw an error but we do lose some info when we only
return combined[0] one line later, though I had some trouble understanding what
the significance of that was.
If that lost info doesn't matter, or if there's a better way to deal with
it, I'm wondering if we need the assertion at all since the pipeline would just
fail on the next line anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
