Abacn commented on code in PR #24447:
URL: https://github.com/apache/beam/pull/24447#discussion_r1037196896
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java:
##########
@@ -681,7 +681,7 @@ private static void fieldDescriptorFromTableField(
new BigDecimal((String) value));
} else if (value instanceof BigDecimal) {
return
BigDecimalByteStringEncoder.encodeToBigNumericByteString(((BigDecimal) value));
- } else if (value instanceof Double || value instanceof Float) {
Review Comment:
We still can have unsupported Number instance, is that right?
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProtoTest.java:
##########
@@ -576,8 +576,8 @@ public void testNestedFromTableSchema() {
new TableCell().setV("00:52:07.123456"),
new TableCell().setV("2019-08-16T00:52:07.123456"),
new TableCell().setV("2019-08-16"),
- new TableCell().setV("23.4"),
Review Comment:
why does this get changed, any breaking change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
