je-ik commented on PR #22889: URL: https://github.com/apache/beam/pull/22889#issuecomment-1334023766
> I wouldn't say it is orthogonal. It is hard to have confidence that something works and isn't regressed without there being good test coverage. Your call if you still want to forge ahead without the tests. 100% agree with the test part. The current code has good coverage, but it builds upon the current implementation detail and it might break. Got your point, I will have a look if I can meaningfully extend the integration test and run in against both classic and portable runners. I'd definitely want to keep the original tests as well, because these tests should be more conclusive (under current implementation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
