Malarg commented on code in PR #24456:
URL: https://github.com/apache/beam/pull/24456#discussion_r1037875520
##########
playground/frontend/playground_components/lib/src/cache/example_cache.dart:
##########
@@ -104,15 +105,17 @@ class ExampleCache extends ChangeNotifier {
);
}
- Future<Example> loadSharedExample(String id) async {
+ Future<Example> loadSharedExample(
+ UserSharedExampleLoadingDescriptor descriptor,
+ ) async {
final result = await _exampleRepository.getSnippet(
- GetSnippetRequest(id: id),
+ GetSnippetRequest(id: descriptor.snippetId),
);
return Example(
sdk: result.sdk,
name: result.files.first.name,
- path: id,
+ path: descriptor.snippetId,
Review Comment:
fixed
##########
playground/frontend/playground_components/lib/src/controllers/playground_controller.dart:
##########
@@ -138,7 +139,8 @@ class PlaygroundController with ChangeNotifier {
[Sdk.java, Sdk.python].contains(sdk);
void setExample(
- Example example, {
+ Example example,
+ ExampleLoadingDescriptor descriptor, {
Review Comment:
fixed
##########
playground/frontend/playground_components/lib/src/models/example_loading_descriptors/content_example_loading_descriptor.dart:
##########
@@ -76,7 +76,7 @@ class ContentExampleLoadingDescriptor extends
ExampleLoadingDescriptor {
}
@override
- List<Object> get props => [content, sdk.id];
+ List<Object> get props => [content, sdk.id, complexity?.name ?? '', name ??
''];
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
