tvalentyn commented on a change in pull request #12115:
URL: https://github.com/apache/beam/pull/12115#discussion_r451988176



##########
File path: sdks/python/container/boot.go
##########
@@ -170,6 +176,28 @@ func main() {
        log.Fatalf("Python exited: %v", execx.Execute("python", args...))
 }
 
+// setup wheel specs according to installed python version
+func setupAcceptableWheelSpecs() error {
+       cmd := exec.Command("python", "-V")
+       stdoutStderr, err := cmd.CombinedOutput()
+       if err != nil {
+               return err
+       }
+       re := regexp.MustCompile(`Python (\d)\.(\d).*`)
+       pyVersions := re.FindStringSubmatch(string(stdoutStderr[:]))
+       if len(pyVersions) != 3 {
+               return fmt.Errorf("cannot get parse Python version from %s", 
stdoutStderr)
+       }
+       pyVersion := fmt.Sprintf("%s%s", pyVersions[1], pyVersions[2])
+       if pyVersion == "27" {
+               acceptableWhlSpecs = append(acceptableWhlSpecs, 
"cp27-cp27mu-manylinux1_x86_64.whl")
+       } else {
+               wheelName := fmt.Sprintf("cp%s-cp%sm-manylinux1_x86_64.whl", 
pyVersion, pyVersion)

Review comment:
       Sorry for a slow response. It seems that 3.8 wheels don't follow this 
pattern, just noticing this while prepring 2.23.0 release. 3.8 wheels look as 
follows:
   
   apache_beam-2.23.0-cp38-cp38-manylinux1_x86_64.whl
   
   Not sure why the pattern has changed. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to