echauchot commented on a change in pull request #12204:
URL: https://github.com/apache/beam/pull/12204#discussion_r452239069
##########
File path:
runners/extensions-java/metrics/src/test/java/org/apache/beam/runners/extensions/metrics/MetricsGraphiteSinkTest.java
##########
@@ -69,20 +69,20 @@ public void testWriteMetricsWithCommittedSupported() throws
Exception {
countDownLatch.await();
String join = String.join("\n", graphiteServer.getMessages());
String regexpr =
- "beam.counter.ns1.n1.committed.value 10 [0-9]+\\n"
- + "beam.counter.ns1.n1.attempted.value 20 [0-9]+\\n"
- + "beam.gauge.ns1.n3.committed.value 100 [0-9]+\\n"
- + "beam.gauge.ns1.n3.attempted.value 120 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.min 5 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.min 3 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.max 8 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.max 9 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.count 2 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.count 4 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.sum 10 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.sum 25 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.mean 5.0 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.mean 6.25 [0-9]+";
+ "beam.counter.ns1.n1.s1.committed.value 10 [0-9]+\\n"
Review comment:
s1 is the step that declares the counter, s2 the step that declares
distribution and s3 is the step that declares gauge.
All the point of this PR is to add missing step names in the graphite sink
message format. So we need to update the test as well to expect the step names
in the output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
