lostluck commented on code in PR #24525:
URL: https://github.com/apache/beam/pull/24525#discussion_r1039932231
##########
sdks/go/pkg/beam/core/runtime/exec/fn_test.go:
##########
@@ -708,11 +708,11 @@ func (c *callerInt) Call1x1(a0 interface{}) interface{} {
// * Implicit or Explicit method Receiver
// * Pre-wrapped values and pre-allocated slices.
// * Invocations along the following ways
-// * Indirect via extracting from a reflect.Value.Interface()
-// * Reflect Package (reflect.Value.Call())
-// * Beam's reflectx.Func, and reflectx.FuncNxM interfaces
-// * Beam's default reflection based reflectx.Func shim
-// * A Type assertion specialized reflectx.Func shim
+// - Indirect via extracting from a reflect.Value.Interface()
+// - Reflect Package (reflect.Value.Call())
+// - Beam's reflectx.Func, and reflectx.FuncNxM interfaces
+// - Beam's default reflection based reflectx.Func shim
+// - A Type assertion specialized reflectx.Func shim
Review Comment:
Technically the sub indents were describing reflectx.Func and
reflectx.FuncNxM respectively, so it was intending to serve a purpose. In this
case, I agree that there's no reason to fuss over it since it was already
broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
