adalbert44 commented on code in PR #24290: URL: https://github.com/apache/beam/pull/24290#discussion_r1040898724
########## sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/schematransform/SingleStoreSchemaTransformReadProvider.java: ########## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.singlestore.schematransform; + +import java.util.Collections; +import java.util.List; +import org.apache.beam.sdk.io.singlestore.SingleStoreIO; +import org.apache.beam.sdk.schemas.Schema; +import org.apache.beam.sdk.schemas.transforms.SchemaTransform; +import org.apache.beam.sdk.schemas.transforms.TypedSchemaTransformProvider; +import org.apache.beam.sdk.transforms.PTransform; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionRowTuple; +import org.apache.beam.sdk.values.Row; + +/** + * An implementation of {@link TypedSchemaTransformProvider} for SingleStoreDB read jobs configured + * using {@link SingleStoreSchemaTransformReadConfiguration}. + */ +public class SingleStoreSchemaTransformReadProvider + extends TypedSchemaTransformProvider<SingleStoreSchemaTransformReadConfiguration> { + + private static final String API = "singlestore"; + private static final String OUTPUT_TAG = "OUTPUT"; + + /** Returns the expected class of the configuration. */ + @Override + protected Class<SingleStoreSchemaTransformReadConfiguration> configurationClass() { + return SingleStoreSchemaTransformReadConfiguration.class; + } + + /** Returns the expected {@link SchemaTransform} of the configuration. */ + @Override + protected SchemaTransform from(SingleStoreSchemaTransformReadConfiguration configuration) { + return new SingleStoreReadSchemaTransform(configuration); + } + + /** Implementation of the {@link TypedSchemaTransformProvider} identifier method. */ + @Override + public String identifier() { + return String.format("%s:read", API); + } + + /** + * Implementation of the {@link TypedSchemaTransformProvider} inputCollectionNames method. Since + * no input is expected, this returns an empty list. + */ + @Override + public List<String> inputCollectionNames() { + return Collections.emptyList(); + } + + /** + * Implementation of the {@link TypedSchemaTransformProvider} outputCollectionNames method. Since + * a single output is expected, this returns a list with a single name. + */ + @Override + public List<String> outputCollectionNames() { + return Collections.singletonList(OUTPUT_TAG); + } + + /** + * An implementation of {@link SchemaTransform} for SingleStoreDB read jobs configured using + * {@link SingleStoreSchemaTransformReadConfiguration}. + */ + private static class SingleStoreReadSchemaTransform implements SchemaTransform { + private final SingleStoreSchemaTransformReadConfiguration configuration; + + SingleStoreReadSchemaTransform(SingleStoreSchemaTransformReadConfiguration configuration) { + this.configuration = configuration; + } + + /** Implements {@link SchemaTransform} buildTransform method. */ + @Override + public PTransform<PCollectionRowTuple, PCollectionRowTuple> buildTransform() { + return new PCollectionRowTupleTransform(configuration); + } + } + + /** + * An implementation of {@link PTransform} for SingleStoreDB read jobs configured using {@link + * SingleStoreSchemaTransformReadConfiguration}. + */ + static class PCollectionRowTupleTransform + extends PTransform<PCollectionRowTuple, PCollectionRowTuple> { + + private final SingleStoreSchemaTransformReadConfiguration configuration; + + PCollectionRowTupleTransform(SingleStoreSchemaTransformReadConfiguration configuration) { + this.configuration = configuration; + } + + @Override + public PCollectionRowTuple expand(PCollectionRowTuple input) { + if (!input.getAll().isEmpty()) { + throw new IllegalArgumentException( + String.format( + "%s %s input is expected to be empty", + input.getClass().getSimpleName(), getClass().getSimpleName())); + } + SingleStoreIO.DataSourceConfiguration dataSourceConfiguration = + configuration.getDataSourceConfiguration(); + String table = configuration.getTable(); + String query = configuration.getQuery(); + Boolean outputParallelization = configuration.getOutputParallelization(); + + SingleStoreIO.ReadRows read = SingleStoreIO.readRows(); + + if (dataSourceConfiguration != null) { + read = read.withDataSourceConfiguration(dataSourceConfiguration); + } + + if (table != null) { Review Comment: spootbug doesn't recognize this check ``` /home/amakarovych-ua/projects/beam/sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/SingleStoreIO.java:343: error: [argument] incompatible argument for parameter password of setPassword. basicDataSource.setPassword(password); ^ found : @Initialized @Nullable String required: @Initialized @NonNull String ``` I will use `table != null && !table.isEmpty()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
