damccorm commented on code in PR #24526:
URL: https://github.com/apache/beam/pull/24526#discussion_r1041157517
##########
sdks/python/apache_beam/transforms/combiners.py:
##########
@@ -517,7 +517,6 @@ def merge_accumulators(self, accumulators, *args, **kwargs):
(holds_comparables, result_heap),
comparable.value if holds_comparables else comparable)
- assert result_heap is not None and holds_comparables is not None
Review Comment:
Not sure I follow why we need the changes beyond `.pre-commit-config.yaml` -
is there a reason we need to change `combiners.py` and `core.py`
##########
.pre-commit-config.yaml:
##########
@@ -11,7 +11,7 @@
# limitations under the License.
default_language_version:
- python: python3.7
+ python: python3
Review Comment:
It looks like `default_language_version` is optional - can we just remove
it? https://pre-commit.com/#top_level-default_language_version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
