echauchot commented on PR #24380: URL: https://github.com/apache/beam/pull/24380#issuecomment-1339624740
> > What I wonder here is that we will drop the whole metric system right ? I remember @mosche you said that it is working only in local mode. Can you elaborate ? > > @echauchot This doesn't drop the metrics system. Currently there's two Spark accumulators registered: > > * `NamedAggregatorsAccumulator` in `AggregatorsAccumulator`: This one isn't used at all, the accumulator is always empty and doesn't expose any API to change that. > * `MetricsContainerStepMapAccumulator` in `MetricsAccumulator`: This is the accumulator that integrates with the `MetricsContainerStepMap` to expose container metrics. > Ah yes, I remember this part from when I worked on the MetricsPusher service. I wanted to ensure that it is not dropped. Fair enough. > I'm only removing the first obsolete part. The metric system integration is kept. Also it's not related to the bug on the Dataset runner i mentioned. ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
