tvalentyn commented on code in PR #24606:
URL: https://github.com/apache/beam/pull/24606#discussion_r1044353611
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -2746,6 +2747,11 @@ def expand(self, pcoll):
combine_fn = self._combine_fn
fanout_fn = self._fanout_fn
+ if self.isinstance(pcoll.windowfn, SlidingWindows):
+ raise ValueError(
+ 'CombinePerKey.with_hot_key_fanout does not yet work properly with
SlidingWindows'
Review Comment:
Thanks.
please reference: https://github.com/apache/beam/issues/20528.
I recommend you import this change internally first before cutting the
release candidate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
