ruslan-ikhsan commented on code in PR #24614:
URL: https://github.com/apache/beam/pull/24614#discussion_r1044383296


##########
playground/terraform/infrastructure/cloudbuild-manual-setup/02.builders/triggers.tf:
##########
@@ -77,5 +77,29 @@ resource "google_cloudbuild_trigger" "playground_to_gke" {
 
   filename = "playground/infrastructure/cloudbuild/cloudbuild_pg_to_gke.yaml"
 
+  service_account = data.google_service_account.cloudbuild_sa.id
+}
+
+resource "google_cloudbuild_trigger" "playground_examples_cd" {
+  name     = var.examples_cd_trigger_name
+  project  = var.project_id
+
+  description = "Runs CD pipeline steps for Playground Examples"
+
+  source_to_build {

Review Comment:
   Since we are doing CD as manual, it should be the way it is, open for 
discussion though



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to