AnandInguva commented on code in PR #23931:
URL: https://github.com/apache/beam/pull/23931#discussion_r1044762155
##########
sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py:
##########
@@ -620,3 +624,13 @@ def __init__(self):
def process(self, element):
yield self.timestamp_val_fn(
element, self.timestamp_fn(micros=int(self.time_fn() * 1000000)))
+
+
+class BigQueryMetricsFetcher:
+ def __init__(self):
+ self.client = bigquery.Client()
Review Comment:
@tvalentyn I created a fetcher for BQ. In the future, if we want to have
influxDB, we can then create a Base Fetcher class and extend from that base
class for both Influx and BQ but for now this should be clear and enough for
our purpose.
##########
sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py:
##########
@@ -620,3 +624,13 @@ def __init__(self):
def process(self, element):
yield self.timestamp_val_fn(
element, self.timestamp_fn(micros=int(self.time_fn() * 1000000)))
+
+
+class BigQueryMetricsFetcher:
+ def __init__(self):
+ self.client = bigquery.Client()
Review Comment:
@tvalentyn I created a fetcher for BQ. In the future, if we want to have
influxDB, we can then create a Base Fetcher class and extend from that base
class for both Influx and BQ but for now this should be clear and enough for
our purpose. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
