TheNeuralBit commented on a change in pull request #12145:
URL: https://github.com/apache/beam/pull/12145#discussion_r452918966
##########
File path: sdks/java/io/expansion-service/build.gradle
##########
@@ -33,6 +33,8 @@ ext.summary = "Expansion service serving several Java IOs"
dependencies {
compile project(":sdks:java:expansion-service")
compile project(":sdks:java:io:kafka")
+ runtime project(":sdks:java:io:jdbc")
runtime library.java.kafka_clients
+ runtime library.java.postgres
Review comment:
nit: It might not be clear why this is here
```suggestion
// Include postgres so it can be used with external JDBC
runtime library.java.postgres
```
##########
File path: CHANGES.md
##########
@@ -55,6 +55,8 @@
* New overloads for BigtableIO.Read.withKeyRange() and
BigtableIO.Read.withRowFilter()
methods that take ValueProvider as a parameter (Java)
([BEAM-10283](https://issues.apache.org/jira/browse/BEAM-10283)).
+* Add cross-language support to
JdbcIO.ReadRows([BEAM-10135](https://issues.apache.org/jira/browse/BEAM-10135)).
+* Add cross-language support to
JdbcIO.Write([BEAM-10136](https://issues.apache.org/jira/browse/BEAM-10136)).
Review comment:
```suggestion
* Add cross-language support to Java's JdbcIO, now available in the Python
module `apache_beam.io.external.jdbc`
([BEAM-10135](https://issues.apache.org/jira/browse/BEAM-10135),
[BEAM-10136](https://issues.apache.org/jira/browse/BEAM-10136)).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
