lukecwik commented on code in PR #24642: URL: https://github.com/apache/beam/pull/24642#discussion_r1046540631
########## runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java: ########## @@ -120,7 +120,6 @@ void setDataflowServiceOptions(List<String> options); /** Run the job as a specific service account, instead of the default GCE robot. */ - @Hidden Review Comment: Does this coincide with the service account that would be used on GCE? If so then this LGTM otherwise I believe the intent was to not propagate this value to the worker (the purpose of `@Hidden`) so there wasn't a mismatch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
