damondouglas opened a new pull request, #24644:
URL: https://github.com/apache/beam/pull/24644
This PR closes #19734 by fixing the `java.lang.AssertionError` of
`WatchTest.testMultiplePollsWithManyResults`.
## `AssertionError` appears after test re-enabling
Prior to the fix, I re-enabled the test, previously disabled by #11614 and
validated `AssertionError` appears.
```bash
# Validate on commit 04a02361eb
echo $(git log -1 --pretty=format:"%h")
```
```bash
for i in `seq 1 100` ; do (
echo "RUN $i" ;
./gradlew :runners:direct-java:cleanTest --quiet
./gradlew :runners:direct-java:needsRunnerTests --quiet --tests
WatchTest.testMultiplePollsWithManyResults
gsutil cp -r
"runners/direct-java/build/reports/tests/needsRunnerTests/classes/org.apache.beam.sdk.transforms.WatchTest.html"
"gs://$BUCKET/$(git log -1 --pretty=format:"%h")/$(date +%s).html"
)
done
```
Intermittently, the error was:
```
Caused by: java.lang.AssertionError: Poll called more than once
Expected: a value greater than <1>
but: <1> was equal to <1>
```
## `AssertionError` resolves after fix
At commit `21caa83468`, executing the above script passed all 100 times.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- ~[ ] Update `CHANGES.md` with noteworthy changes.~
- ~[ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).~
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
