riteshghorse commented on code in PR #24497:
URL: https://github.com/apache/beam/pull/24497#discussion_r1047270007
##########
sdks/go/pkg/beam/core/runtime/graphx/translate.go:
##########
@@ -687,6 +688,20 @@ func (m *marshaller) expandCrossLanguage(namedEdge
NamedEdge) (string, error) {
EnvironmentId: m.addDefaultEnv(),
}
+ // Add the coders for output in the marshaller even if expanded is nil
+ // for output coder field in expansion request.
+ // We need this specifically for Python External Transforms.
+ names := strings.Split(spec.Urn, ":")
+ if len(names) > 2 && names[2] == "python" {
Review Comment:
We don't need to but I just added it so that it won't need to do this for
every external transform. But yeah unlocking sounds scalable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
