Abacn commented on PR #24653: URL: https://github.com/apache/beam/pull/24653#issuecomment-1350283868
Actually the previous comment is not true. If the file is already deleted it does not raise Exception, see https://github.com/apache/beam/blob/77af3237521d94f0399ab405ebac09bbbeded38c/sdks/python/apache_beam/io/aws/s3io.py#L322 https://github.com/apache/beam/blob/77af3237521d94f0399ab405ebac09bbbeded38c/sdks/python/apache_beam/io/azure/blobstorageio.py#L447 https://github.com/apache/beam/blob/77af3237521d94f0399ab405ebac09bbbeded38c/sdks/python/apache_beam/io/gcp/gcsio.py#L281 In other words, if there is an exception here there is an http error for the file deletion. The description in #24638 may instead indicate an actual bug. I think the deletion operation should get retried upon retriable http error, and it should reduce the occurrence of #24638; and if there is still an error, yes, we should emit a warning and print the error message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
