je-ik commented on code in PR #22889:
URL: https://github.com/apache/beam/pull/22889#discussion_r1048634640
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/stableinput/BufferingDoFnRunner.java:
##########
@@ -85,6 +86,8 @@ public static <InputT, OutputT> BufferingDoFnRunner<InputT,
OutputT> create(
int currentStateIndex;
/** The current handler used for buffering. */
private BufferingElementsHandler currentBufferingElementsHandler;
+ /** Minimum timestamp of all buffered elements. */
+ private volatile long currentOutputWatermarkHold;
Review Comment:
changed the name to `minBufferedElementTimestamp`
##########
runners/flink/src/test/java/org/apache/beam/runners/flink/PortableExecutionTest.java:
##########
@@ -38,10 +38,15 @@
import org.apache.beam.sdk.transforms.DoFn;
import org.apache.beam.sdk.transforms.GroupByKey;
import org.apache.beam.sdk.transforms.Impulse;
+import org.apache.beam.sdk.transforms.MapElements;
Review Comment:
Fixed and used the IT test for both classic and portable runners.
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/stableinput/BufferingDoFnRunner.java:
##########
@@ -164,6 +171,8 @@ public <KeyT> void onTimer(
Instant timestamp,
Instant outputTimestamp,
TimeDomain timeDomain) {
+
+ currentOutputWatermarkHold = Math.min(timestamp.getMillis(),
currentOutputWatermarkHold);
Review Comment:
Yes, I fixed the independently. Unfortunately, there is some other buf with
timers in stable do fn.
See https://github.com/apache/beam/issues/24662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
