damondouglas commented on code in PR #24669:
URL: https://github.com/apache/beam/pull/24669#discussion_r1049053869
##########
sdks/java/harness/jmh/src/main/java/org/apache/beam/fn/harness/jmh/ProcessBundleBenchmark.java:
##########
@@ -185,23 +184,21 @@ public void log(LogEntry entry) {
}
@TearDown
- public void tearDown() throws Exception {
- controlServer.close();
- stateServer.close();
- dataServer.close();
- loggingServer.close();
- controlClient.close();
- sdkHarnessExecutor.shutdownNow();
- serverExecutor.shutdownNow();
+ public void tearDown() {
try {
+ controlServer.close();
+ stateServer.close();
+ dataServer.close();
+ loggingServer.close();
+ controlClient.close();
sdkHarnessExecutorFuture.get();
- } catch (ExecutionException e) {
- if (e.getCause() instanceof RuntimeException
- && e.getCause().getCause() instanceof InterruptedException) {
- // expected
- } else {
- throw e;
- }
+ } catch (InterruptedException ignored) {
+ // expected
Review Comment:
Fixing... thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]