damccorm commented on code in PR #24668:
URL: https://github.com/apache/beam/pull/24668#discussion_r1049831574
##########
sdks/go/pkg/beam/core/runtime/graphx/translate.go:
##########
@@ -83,14 +84,18 @@ const (
URNArtifactURLType = "beam:artifact:type:url:v1"
URNArtifactGoWorkerRole = "beam:artifact:role:go_worker_binary:v1"
- // Environment Urns.
+ // Environment URNs.
URNEnvProcess = "beam:env:process:v1"
URNEnvExternal = "beam:env:external:v1"
URNEnvDocker = "beam:env:docker:v1"
- // Userstate Urns.
+ // Userstate URNs.
URNBagUserState = "beam:user_state:bag:v1"
URNMultiMapUserState = "beam:user_state:multimap:v1"
+
+ // Base version URNs are to allow runners to make distinctions between
different releases
+ // in a way that won't change based on actual releases, in particular
for FnAPI behaviors.
+ URNBaseVersionGo = "beam:version:sdk_base:go:" + core.DefaultDockerImage
Review Comment:
Is there a reason we're using the DefaultDockerImage as the identifier
instead of the SdkVersion? They should be equally unique, but `SdkVersion`
seems like a more natural identifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
