eantyshev commented on code in PR #24751:
URL: https://github.com/apache/beam/pull/24751#discussion_r1056201116
##########
playground/infrastructure/helper.py:
##########
@@ -98,11 +99,17 @@ def find_examples(root_dir: str, subdirs: List[str], sdk:
SdkEnum) -> List[Examp
for filename in files:
filepath = os.path.join(root, filename)
try:
- example = _load_example(
- filename=filename, filepath=filepath, sdk=sdk
- )
- if example is not None:
- examples.append(example)
+ try:
+ example = _load_example(
+ filename=filename, filepath=filepath, sdk=sdk
+ )
+ if example is not None:
+ examples.append(example)
+ except pydantic.ValidationError as err:
+ if len(err.errors()) > 1:
+ raise
+ if err.errors()[0]["msg"] == "multifile is True but no
files defined":
+ logging.warning("incomplete multifile example
ignored %s", filepath)
Review Comment:
good point, fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
