bullet03 commented on code in PR #22221:
URL: https://github.com/apache/beam/pull/22221#discussion_r1058193317
##########
website/www/check-links.sh:
##########
@@ -67,25 +99,54 @@ mapfile -t external_links < <(printf '%s\n' "${links[@]}" |
grep "^https\?://" |
echo "Found ${#links[@]} links including ${#external_links[@]} unique external
links."
echo "Checking links."
+prod_exception_links=()
+staging_exception_links=()
+check_absolute_links "production" "beam.apache.org" prod_exception_links
+check_absolute_links "staging"
"apache-beam-website-pull-requests.storage.googleapis.com"
staging_exception_links
+
+echo "Checking working links."
+verified_list="https://reporter.apache.org/addrelease.html?beam,https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork,https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/,https://qwiklabs.com/focuses/608?locale=en&parent=catalog,https://www.artstation.com/jbruno,https://www.qwiklabs.com/focuses/1098?parent=catalog,https://www.infoworld.com/article/3336072/infoworlds-2019-technology-of-the-year-award-winners.html,https://be.linkedin.com/in/mattcasters,https://www.linkedin.com/company/beam-summit/,https://www.linkedin.com/company/beam-summit/?viewAsMember=true,https://www.ricardo.ch/,https://www.linkedin.com/company/apache-beam/,https://repository.apache.org/content/repositories/orgapachebeam-NNNN/),https://www.meetup.com/Apache-Beam-Stockholm/?_cookie-check=v_YHSSjYcT9rpm61,https://www.meetup.com/Apache-Beam-Stockholm/events/260634514";
invalid_links=()
-i=1
-for external_link in "${external_links[@]}"
-do
- redraw_progress_bar 50 1 $i ${#external_links[@]}
- if ! curl -sSfL --max-filesize 1000000 --max-time 10 --connect-timeout 10
--retry 2 -4 "${external_link}" > /dev/null ; then
- invalid_links+=("${external_link}")
- echo "${external_link}"
- fi
- i=$((i+1))
-done
-# Clear line - hide progress bar
-echo -n -e "\033[2K"
+function handleUrls {
Review Comment:
> nit: use the same naming style format, rename to `handle_urls`
changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
