Abacn commented on code in PR #24204:
URL: https://github.com/apache/beam/pull/24204#discussion_r1058408893
##########
.test-infra/jenkins/job_PreCommit_Python.groovy:
##########
@@ -22,6 +22,9 @@ PrecommitJobBuilder builder = new PrecommitJobBuilder(
scope: this,
nameBase: 'Python',
gradleTask: ':pythonPreCommit',
+ gradleSwitches: [
Review Comment:
Did we miss IO unit tests?
In general, I am thinking about an exclude list for this "remaining"
precommit may be more preferrable, so that we do not miss, and no need to
change here when new module being added, however not sure how to implement this
either... @tvalentyn any thought?
##########
sdks/python/test-suites/tox/py38/build.gradle:
##########
@@ -26,6 +26,10 @@ applyPythonNature()
// Required to setup a Python 3 virtualenv and task names.
pythonVersion = '3.8'
+def posargs = project.findProperty("posargs") ?: ""
+def runDataframesTests = (posargs == "" || posargs.contains("dataframes"))
Review Comment:
py38/build.gradle has more content than other versions and these additional
contents are for precommit running on a single version. We should gather these
single version lines together (under comment TODO(BEAM-12000) below) to make
future version bump easier.
##########
.test-infra/jenkins/job_PreCommit_Python_Dataframe.groovy:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import PrecommitJobBuilder
+
+PrecommitJobBuilder builder = new PrecommitJobBuilder(
+ scope: this,
+ nameBase: 'Python_Dataframe',
+ gradleTask: ':pythonPreCommit',
+ gradleSwitches: [
+ '-Pposargs=apache_beam/dataframe/'
+ ],
+ timeoutMins: 180,
+ triggerPathPatterns: [
Review Comment:
so we do not yet change trigger pattern (e.g.. Gating precommits to tighter
directories) in this PR (fine to me).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
