Abacn commented on code in PR #24803:
URL: https://github.com/apache/beam/pull/24803#discussion_r1058656898
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubClient.java:
##########
@@ -506,9 +506,9 @@ public abstract List<SubscriptionPath>
listSubscriptions(ProjectPath project, To
*/
public abstract boolean isEOF();
- /** Create {@link com.google.api.services.pubsub.model.Schema} from resource
path. */
+ /** Create {@link com.google.api.services.pubsub.model.Schema} from Schema
definition content. */
public abstract void createSchema(
Review Comment:
I understand this method is just introduced last week (#24443) and a change
of parameter type should not introduce breaking change to released versions.
However I would like to understand how "public" the PubSubClient abstract class
is? Suppose users have their own pubsub client implementation adding a new
abstract method would break them. Or, users are not supposed to implement their
own client but the "public" here is for the usage of other modules within Beam
SDK. In the latter case, we should add some javadoc to the base abstract class
warning that "internal use only, no backward compatibility guaranteed."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
