mutianf commented on code in PR #24015: URL: https://github.com/apache/beam/pull/24015#discussion_r1059145811
########## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableClientWrapper.java: ########## @@ -0,0 +1,94 @@ +/* Review Comment: I wanted to keep `BigtableHBaseVeneerSettings` class package private. `BigtableHBaseVeneerSettings` exposes some surfaces from gax and I don't want anyone to call it directly. i'll also need to make a lot of changes in GcpApiSurfaceTest for it to pass if `BigtableHBaseVeneerSettings` is public and marked with `@Internal`. Moving the `BigtableClientWrapper` seems to be an easier change, but let me know if you want to keep the original structure! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
