Malarg commented on code in PR #24820: URL: https://github.com/apache/beam/pull/24820#discussion_r1059239951
########## playground/frontend/lib/constants/assets.dart: ########## @@ -23,6 +23,7 @@ const kOutputRightIconAsset = 'output_right.svg'; const kOutputLeftIconAsset = 'output_left.svg'; const kShortcutsIconAsset = 'shortcuts.svg'; const kGithubIconAsset = 'github.svg'; +const kColabIconAsset = 'colab.svg'; Review Comment: I don't think, that it's a good idea, because in this PR we are depends on colab link code on backend. So if we try to create PR on that branch with this code, where will be a lot of additional changes. I think it will be better to resolve conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
