dpcollins-google commented on a change in pull request #11919:
URL: https://github.com/apache/beam/pull/11919#discussion_r453645357
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Reshuffle.java
##########
@@ -109,16 +110,33 @@ public void processElement(
public static class ViaRandomKey<T> extends PTransform<PCollection<T>,
PCollection<T>> {
private ViaRandomKey() {}
+ private ViaRandomKey(@Nullable Integer numBuckets) {
+ this.numBuckets = numBuckets;
+ }
+
Review comment:
These are only minor changes to the transform and this is the only file
not directly related to pubsub lite io that is changed. Given the high latency
on merging beam PRs and the fact that this change was proposed in this pr (see
millsd@ comments above), I'd prefer not to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
