TSultanov commented on code in PR #24818:
URL: https://github.com/apache/beam/pull/24818#discussion_r1062521075
##########
playground/infrastructure/datastore_client.py:
##########
@@ -44,10 +44,10 @@ class DatastoreClient:
_datastore_client: datastore.Client
- def __init__(self):
+ def __init__(self, namespace: str):
self._check_envs()
self._datastore_client = datastore.Client(
- namespace=DatastoreProps.NAMESPACE,
project=Config.GOOGLE_CLOUD_PROJECT
+ namespace=namespace, project=Config.GOOGLE_CLOUD_PROJECT
Review Comment:
Moved this configuration option from environment variable to the `ci_cd.py`
script arguments and updated the ci/cd configs which use this script
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
