apilloud commented on a change in pull request #12231:
URL: https://github.com/apache/beam/pull/12231#discussion_r453757456
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamBigQuerySqlDialect.java
##########
@@ -359,6 +267,43 @@ private void unparseFunctionsUsingInterval(
}
}
+ private void unparseExtractFunctions(
+ SqlWriter writer, SqlCall call, int leftPrec, int rightPrec) {
+ String funName = call.getOperator().getName();
+ int operandCount = call.operandCount();
+ SqlNode tz = null;
Review comment:
nit: Looks like this should be set exactly once below? consider making
it `final SqlNode tz;` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
