alexeyinkin commented on code in PR #24865: URL: https://github.com/apache/beam/pull/24865#discussion_r1063235740
########## playground/frontend/playground_components/lib/src/controllers/snippet_file_editing_controller.dart: ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import 'dart:math'; + +import 'package:flutter/widgets.dart'; +import 'package:flutter_code_editor/flutter_code_editor.dart'; +import 'package:get_it/get_it.dart'; + +import '../models/example_view_options.dart'; +import '../models/sdk.dart'; +import '../models/snippet_file.dart'; +import '../services/symbols/symbols_notifier.dart'; + +/// The main state object for a file in a snippet. +class SnippetFileEditingController extends ChangeNotifier { + final CodeController codeController; + final SnippetFile savedFile; + final Sdk sdk; + + bool _isChanged = false; + + final _symbolsNotifier = GetIt.instance.get<SymbolsNotifier>(); + + SnippetFileEditingController({ + required this.savedFile, + required this.sdk, + required ExampleViewOptions viewOptions, + int? contextLine1Based, + }) : codeController = CodeController( + language: sdk.highlightMode, + namedSectionParser: const BracketsStartEndNamedSectionParser(), + text: savedFile.content, + ) { + _applyViewOptions(viewOptions); + if (contextLine1Based != null) { + _toStartOfFullLine(max(contextLine1Based - 1, 0)); + } + + codeController.addListener(_onCodeControllerChanged); + _symbolsNotifier.addListener(_onSymbolsNotifierChanged); + _onSymbolsNotifierChanged(); + } + + void _applyViewOptions(ExampleViewOptions options) { + codeController.readOnlySectionNames = options.readOnlySectionNames.toSet(); + codeController.visibleSectionNames = options.showSectionNames.toSet(); + + if (options.foldCommentAtLineZero) { + codeController.foldCommentAtLineZero(); + } + + if (options.foldImports) { + codeController.foldImports(); + } + + final unfolded = options.unfoldSectionNames; + if (unfolded.isNotEmpty) { + codeController.foldOutsideSections(unfolded); + } + } + + void _toStartOfFullLine(int line) { + if (line >= codeController.code.lines.length) { + return; + } + + final fullPosition = codeController.code.lines.lines[line].textRange.start; + final visiblePosition = codeController.code.hiddenRanges.cutPosition( + fullPosition, + ); + + codeController.selection = TextSelection.collapsed( + offset: visiblePosition, + ); + } + + void _onCodeControllerChanged() { + if (!_isChanged) { + if (_isCodeChanged()) { + _isChanged = true; + notifyListeners(); + } + } else { + _updateIsChanged(); + if (!_isChanged) { + notifyListeners(); + } + } + } + + bool get isChanged => _isChanged; + + bool _isCodeChanged() { + return savedFile.content != codeController.fullText; + } + + void _updateIsChanged() { + _isChanged = _isCodeChanged(); + } + + void reset() { + codeController.text = savedFile.content; + } + + void _onSymbolsNotifierChanged() { + final mode = sdk.highlightMode; + if (mode == null) { + return; + } + + final dictionary = _symbolsNotifier.getDictionary(mode); + if (dictionary == null) { + return; + } + + codeController.autocompleter.setCustomWords(dictionary.symbols); + } + + SnippetFile getFile() => SnippetFile( + content: codeController.fullText, + isMain: savedFile.isMain, + name: savedFile.name, + ); + + @override + void dispose() { Review Comment: I guess `CodeController` and `SnippetFileEditingController` should be deleted together, and the garbage collector should handle the circular references. Even if it does not now, it is their job for future, and if we micromanage this now we will not gain much but will have more things to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
